-
Notifications
You must be signed in to change notification settings - Fork 0
Evolve requirements #150
Open
donald
wants to merge
47
commits into
master
Choose a base branch
from
evolve-requirements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Evolve requirements #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9e303f to
152eb82
Compare
Member
Author
|
We have one bad page, where body and body_en are empty and body_de has content wich is not JSON but plain HTML: Probably a previous migration from HTML to JSON skipped body_de because of the empty body. Not he invalid json makes the Same with event 5: |
5a3e4e7 to
91497f2
Compare
Avoid W042 warnings like base.FeaturedImage: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'. HINT: Configure the DEFAULT_AUTO_FIELD setting or the BaseAppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
Avoid warning like base.FormPage: (wagtailsearch.W001) Core Page fields missing in `search_fields` HINT: Ensure that FormPage extends the Page model search fields `search_fields = Page.search_fields + [...]`
Note: We should set that to True because that is going to become default in a later Wagtail version. However, there were migration problems when going from False to True so we postpone that until other problems are fixed and we have a runnable stack.
During debugging, we sometimes get a warning, that intranet.molgen.mpg.de is not in ALLOWED_HOSTS during edit and preview. Is it unclear why this is required, but allow that for now and investigate later.
Created by `./manage.py makemigrations`
Switch database field to json. This will be the only option in future Wagtail versions anyway.
The fix is upstream now.
Remove this patch. Hopefully, "settings/local: Add intranet.molgen.mpg.de to ALLOWED_HOSTS" fixed the same problem.
modeladmin is deprecated. Add it as an external package to ease transition. In the longterm, the usages should be converted to wagtail.snippets.
Wagtail's add_subpage.html now unpacks a 4-tuple including page_description, so include model.get_page_description() in the page_types list.
Python 3.12 changed cProfile to use sys.monitoring internally, which has a limited number of globally-shared tool slots. Concurrent requests both trying to enable a cProfile.Profile() cause the second one to fail with "ValueError: Another profiling tool is already active". See https://github.com/django-commons/django-debug-toolbar/issues/1875
Wagtail 6.0 renames the classnames kwarg to classname. See RemovedInWagtail60Warning.
Browsers request /favicon.ico unconditionally, causing a 404.
The feature used li.object.stream-field as the styling target, which no longer exists in the Wagtail 5.x admin. The replacement (section.w-panel) covers too wide an area and does not look good in the new design. Keep the flag emoji labels on [de]/[en] fields.
Wagtail 5.x renders translated field headings as span[data-panel-heading-text] rather than <label>. Use that selector to append flag emojis after [de]/[en] markers.
wagtail.search.models.Query moved to wagtail.contrib.search_promotions.models in Wagtail 6.
WAGTAIL_USER_EDIT_FORM is deprecated in Wagtail 6 and removed in Wagtail 7. Replace it with a UserViewSet subclass that overrides get_form_class().
get_user_edit_form was removed from wagtail.users.views.users in Wagtail 6.
Required by Wagtail's database search backend for SearchVectorField.
91497f2 to
74c6410
Compare
We get a lot of warnings which might confuse our editors, disable them for now.
35fb7b5 to
31bb387
Compare
VideoBlock was superseded by VideoChooserBlock from the wagtailvideos package. It is no longer referenced in live code, only in old migrations. Replace it with a self-contained stub in each migration file so the migrations remain importable without the original implementation.
Created by `(cd requirements && rm *.txt && make)`.
Run
./manage.py makemessages -l de
Note: This commit removes many lines from django.po because in the past
the above command was run with the virtual environemnt visible in the
subdirectory "venv0" and walking over the installed Python packages.
This has been changed, the virtual environement is now hidden (".venv")
and makemessages no longer collects messages from python packages, which
is correct.
Wagtail renamed results.html to index_results.html and moved the header rendering into the generic index view, making the local override redundant.
81a8b8a to
8dcc43d
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #148
Deploy with
Note, that wsgi needs the same python version